Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config params for trip survey upload folder and file prefix #302

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Config params for trip survey upload folder and file prefix #302

merged 1 commit into from
Feb 6, 2025

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [na] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR makes the S3 folder and file prefix for the compiled trip surveys configurable. New optional config params:

  • TRIP_SURVEY_RESPONSES_FILE_PREFIX for the file names
  • TRIP_SURVEY_RESPONSES_FOLDER for the S3 folder of the existing connected data platform bucket.

br648
br648 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Feb 4, 2025
josh-willis-arcadis
josh-willis-arcadis approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@binh-dam-ibigroup binh-dam-ibigroup merged commit cb32a33 into dev Feb 6, 2025
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the rename-trip-survey-response-files branch February 6, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @br648 @josh-willis-arcadis