fix(check-monitored-trip): advance to next trip day when itinerary is no longer valid #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no longer monitored on a day
br648
approved these changes
Dec 23, 2024
| import java.util.Locale; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.*; |
There was a problem hiding this comment.
We use explict imports. Can you revert this please. There is also a setting in Intellij (assuming you are using this) that prevents this.
| @@ -771,6 +764,33 @@ public boolean shouldSkipMonitoredTripCheck(boolean persist) throws Exception { | |||
| return true; | |||
| } | |||
|
|
|||
| // Check if previous matching itinerary day is still valid | |||
There was a problem hiding this comment.
Please change this to a method comment. Start with /** and end with */
| Calendar calendar = Calendar.getInstance(); | ||
| calendar.setTime(previousMatchingItinerary.startTime); | ||
|
|
||
| int dayOfWeek = calendar.get(Calendar.DAY_OF_WEEK); |
There was a problem hiding this comment.
Nit. You could in-line this variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
After submitting a trip with certain monitored days, the next trip can be shown on a day that is not monitored. Adds a check on the previous matching itinerary against days the trip should be monitored.