OTP-1465 Schedule Trip History Uploade #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Nov 27, 2024
| var now = DateTimeUtils.nowAsZonedDateTime(DateTimeUtils.getOtpZoneId()); | ||
| var timeOfDay = LocalTime.parse(CONNECTED_DATA_PLATFORM_TRIP_HISTORY_UPLOAD_START_TIME); | ||
| var startAt = DateTimeUtils.getNextTimeFrom(timeOfDay, now); | ||
| long initialDelayMinutes = Duration.between(now, startAt).toMinutes(); |
There was a problem hiding this comment.
One detail that I overlooked is that the configured start time should only apply if the uploads are daily (CONNECTED_DATA_PLATFORM_REPORTING_INTERVAL = "daily"). If the reporting interval is hourly, the job should still start immediately.
There was a problem hiding this comment.
Extract a method to compute the initial delay (lines 122 to 125), and place it in DateTimeUtils or Scheduler, and add a unit test for that method.
| var zdt = ZonedDateTime.of(2024, 11, 11, 15, 34, 17, 0, DateTimeUtils.getOtpZoneId()); | ||
| var timeOfDay = LocalTime.parse("05:15"); | ||
| var zdtNext = DateTimeUtils.getNextTimeFrom(timeOfDay, zdt); | ||
| assertTrue(zdtNext.isAfter(zdt)); |
There was a problem hiding this comment.
Since you are using an absolute date zdt, can you assert on the date, hour, and minutes instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
OTP-1465: Schedule initial trip history upload at 3:00 AM instead of right away. Utility method finds next occurrence of 3:00 AM (or any time of day), which will be today or tomorrow, and scheduler is invoked with an initial delay to that time.
A new
CONNECTED_DATA_PLATFORM_TRIP_HISTORY_UPLOAD_START_TIMEconfiguration setting is introduced with a default value of"03:00".Some OTP-1444 code was written concurrently, a different upload/transfer job. This same code could be used for that, but the two branches would need to be merged.