Send bus notifications if first leg is bus #264
Conversation
|
@binh-dam-ibigroup the test that is failing also fails under dev. I think it is a time/locale issue. I bet it will work when I re-run it tomorrow morning! Failed test has this comment: |
| * Given the traveler's position and leg type, check if bus notification should be sent. | ||
| */ | ||
| public static boolean shouldNotifyBusOperator(TravelerPosition travelerPosition, boolean isStartOfTrip) { | ||
| return (isStartOfTrip) |
There was a problem hiding this comment.
Extract a variable for the leg to pass to isBusLeg and isWithinOperationalNotifyWindow depending on isStartOfTrip, and remove line 180.
| @@ -136,10 +136,7 @@ public static TripInstruction alignTravelerToTrip( | |||
| Locale locale = travelerPosition.locale; | |||
|
|
|||
| if (isApproachingEndOfLeg(travelerPosition)) { | |||
There was a problem hiding this comment.
If this is at the start of a trip where the first leg is transit, there is no approaching the end of the leg.
There was a problem hiding this comment.
@binh-dam-ibigroup If possible can you provide a trip which starts with a transit leg? I'm going to edit an existing trip (walk-to-bus-transition.json) to test with, but would prefer a real-world exampl
Checklist
devbefore they can be merged tomaster)Description
If the trip starts with a bus leg notify bus op.