Post deviated trip notification #260
Conversation
| /** | ||
| * Get users whose last trip survey notification was at least a week ago. | ||
| */ | ||
| public static List<OtpUser> getUsersWithNotificationsOverAWeekAgo() { |
There was a problem hiding this comment.
Is or should there be a option to opt-out of receiving surveys?
There was a problem hiding this comment.
No opt-out of post-travel surveys at the moment.
| @@ -84,6 +85,16 @@ public static void main(String[] args) throws IOException, InterruptedException | |||
| 1, | |||
| TimeUnit.MINUTES | |||
| ); | |||
|
|
|||
| // Schedule recurring job for post-trip surveys, once every few hours | |||
| // TODO: Determine whether this should go in some other process. | |||
There was a problem hiding this comment.
I think the trigger location is fine. Perhaps follow the approach of ConnectedDataManager.scheduleTripHistoryUploadJob(); and have the schduler in the class. It might also be benefical to have the ability to disable this via a config property.
| Scheduler.scheduleJob( | ||
| tripSurveySenderJob, | ||
| 0, | ||
| 12, |
There was a problem hiding this comment.
Do we want to send notifications potentially in the early hours of the morning? Do we care? Might get a better response in working hours.
There was a problem hiding this comment.
Morning local time sounds good. Do you know how to do that with this scheduler?
There was a problem hiding this comment.
Workout the diff between now and the next 9am in seconds and use that as the initial delay. Time unit used by the scheduler would have to be seconds.
There was a problem hiding this comment.
Change on when notifications are sent: within 20-30 minutes of trip completion.
| @@ -76,6 +77,9 @@ public enum Notification { | |||
| /** Whether to store the user's trip history (user must opt in). */ | |||
| public boolean storeTripHistory; | |||
|
|
|||
| /** When the last post-trip survey notification was sent. */ | |||
| public Date lastTripSurveyNotificationSent; | |||
There was a problem hiding this comment.
This is only referenced in tests. I think it is updated via the field reference above, so is required at a DB level?
There was a problem hiding this comment.
Yes, this field is needed to keep track of when a post-travel notification was sent when subsequent trips are completed.
| } | ||
|
|
||
| @Test | ||
| void canGetUsersWithNotificationsOverAWeekAgo() { |
There was a problem hiding this comment.
This test fails for me: expected: <2> but was: <3>. Perhaps OS?
…hold to select trips.
Checklist
devbefore they can be merged tomaster)Description
This PR sets up a job to send post-trip surveys for users who took trips the day before.
Blockers: