OTP-888 Swagger including mobility profiles. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2550,8 +2550,18 @@ definitions: | |||
| type: "boolean" | |||
| hasConsentedToTerms: | |||
| type: "boolean" | |||
| isMobilityLimited: | |||
There was a problem hiding this comment.
Main reason why you want to publish a PR branch quickly for review: I see that the mobility attributes start to stack up, and my thought was to put them under a mobilityProfile field:
- <other OTP User attributes>
- mobilityProfile
- isMobiityLimited
- mobilityDevices
- mobilityMode
- visionLimitation
There was a problem hiding this comment.
I'm putting together a mobilityProfile field as requested.
binh-dam-ibigroup
approved these changes
Nov 30, 2023
miles-grant-ibigroup
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Add mobility profile support. New fields in
OtpUser(in this code and in Mongo and Swagger). Following the logic, naming, and strings in the Georgia Tech document, a somewhat unwieldy newOtpUserController#calculateMobilityMode()that takes specified string values and calculates a "mobility mode" keyword or compound keyword.This PR should include the 08d9695 commits.