Improve trip alert template (push + email) #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianaCeric
changed the title
…files are first generated and need to be regenerated when template files are changed.
|
I stuck a Javadoc comment on the unit test, to describe the magical behind-the-scenes snapshot file creation. |
JymDyerIBI
approved these changes
Dec 14, 2023
|
Thanks for the Javadoc @JymDyerIBI ! |
binh-dam-ibigroup
requested changes
Dec 14, 2023
src/main/java/org/opentripplanner/middleware/models/TripMonitorNotification.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/middleware/tripmonitor/jobs/CheckMonitoredTrip.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/middleware/utils/TemplateUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/middleware/utils/TemplateUtilsTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
431
to
438
| "notifications", new ArrayList<>(notifications).stream() | ||
| // Make certain notifications, such as the initial reminder one, appear on top. | ||
| .sorted(Comparator.comparingInt(TripMonitorNotification::sortOrder)) | ||
| .map(notification -> notification.body) | ||
| .map(notification -> Map.of( | ||
| "type", notification.type.toString(), | ||
| "body", notification.body | ||
| )) | ||
| .collect(Collectors.toList()) |
There was a problem hiding this comment.
Haha I think this should be simply:
Suggested change
| "notifications", new ArrayList<>(notifications).stream() | |
| // Make certain notifications, such as the initial reminder one, appear on top. | |
| .sorted(Comparator.comparingInt(TripMonitorNotification::sortOrder)) | |
| .map(notification -> notification.body) | |
| .map(notification -> Map.of( | |
| "type", notification.type.toString(), | |
| "body", notification.body | |
| )) | |
| .collect(Collectors.toList()) | |
| "notifications", new ArrayList<>(notifications) |
binh-dam-ibigroup
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Push
Bullet point only present if >1 alert
Email
Also moves initial reminder ("Reminder for your upcoming trip...") outside of the list and to top of email