Retrieve push devices when returning user profile #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@binh-dam-ibigroup - It's suggesting you as a reviewer, which makes no sense. Maybe you'll have better luck with a reviewer suggestion? |
Was that an AI suggestion lol? |
binh-dam-ibigroup
assigned daniel-heppner-ibigroup and unassigned binh-dam-ibigroup and JymDyerIBI
daniel-heppner-ibigroup
approved these changes
Nov 14, 2023
| @@ -324,6 +325,14 @@ public static int getPushInfo(String toUser) { | |||
| return 0; | |||
| } | |||
|
|
|||
| public static void updatePushDevices(OtpUser otpUser) { | |||
There was a problem hiding this comment.
Is there any expectation to add Javadoc in this project?
There was a problem hiding this comment.
I added the JavaDoc in c7b05af.
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR makes OTP-middleware retrieve the number of push devices when user info is requested. This is useful for new users that have opened the mobile app but have yet to start saving trips.