refactor(TripMonitorNotification): Remove the initial reminder text a…

…bout "We'll let you know..."
ibi-group · Nov 29, 2023 · d3e9b9f · d3e9b9f
1 parent 27efbf4
commit d3e9b9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/main/java/org/opentripplanner/middleware/models/TripMonitorNotification.java b/src/main/java/org/opentripplanner/middleware/models/TripMonitorNotification.java
@@ -106,19 +106,12 @@ public static TripMonitorNotification createItineraryNotFoundNotification(
      * Creates an initial reminder of the itinerary monitoring.
      */
     public static TripMonitorNotification createInitialReminderNotification(
-        MonitoredTrip trip,
-        boolean noOtherNotifications
+        MonitoredTrip trip
     ) {
         // TODO: i18n.
-        StringBuilder body = new StringBuilder();
-        body.append(String.format("Reminder for %s at %s.", trip.tripName, trip.tripTime));
-        if (noOtherNotifications) {
-            body.append("\n");
-            body.append("We will notify you know if anything changes.");
-        }
         return new TripMonitorNotification(
             NotificationType.INITIAL_REMINDER,
-            body.toString()
+            String.format("Reminder for %s at %s.", trip.tripName, trip.tripTime)
         );
     }
 

diff --git a/src/main/java/org/opentripplanner/middleware/tripmonitor/jobs/CheckMonitoredTrip.java b/src/main/java/org/opentripplanner/middleware/tripmonitor/jobs/CheckMonitoredTrip.java
@@ -142,7 +142,7 @@ private void addInitialReminderIfNeeded() {
 
         if (!trip.isInactive() && isFirstTimeCheckWithinLeadMonitoringTime && userWantsInitialReminder) {
             enqueueNotification(
-                TripMonitorNotification.createInitialReminderNotification(trip, notifications.isEmpty())
+                TripMonitorNotification.createInitialReminderNotification(trip)
             );
         }
     }