Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Usage Chart Repair #85

Merged
merged 2 commits into from
Mar 13, 2024
Merged

API Usage Chart Repair #85

merged 2 commits into from
Mar 13, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

Corrects some assumptions made during the development of these graphs. Most notable is a new USAGE_ID filter which lets you only show graphs and stats from a certain usage id.

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Mar 5, 2024
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
arc-otp-admin-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:46pm
atlrides-otp-admin-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:46pm
otp-admin-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:46pm
st-otp-admin-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:46pm

Copy link

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is the logic right? Maybe I don't understand

{
/* If we're specifying a USAGE_ID then we definitely don't want to
be creating API keys in that AWS environment! */
isApiManagerEnabled() && USAGE_ID === null && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be enabling account creation when USAGE_ID is null? Shouldn't it be the opposite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If USAGE_ID is set, then we don't have full access to the AWS instance, so probably shouldn't be creating AWS users and keys! If it is UNset, then we are safe to do so

@miles-grant-ibigroup miles-grant-ibigroup merged commit 31afc3b into dev Mar 13, 2024
8 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the api-usage-chart-repair branch March 13, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants