Signup form validation #22
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ibi-group/otp-admin-ui/jz6l998fu |
| onChange={handleChange} | ||
| type='checkbox' | ||
| /> | ||
| </Form.Group> |
There was a problem hiding this comment.
I find it somewhat weird to handle this checkbox differently than the items in field layout. I would kind of expect that the fields are either all included in the field layout object or all explicitly written out in the jsx markup. This isn't blocking though
| // "detail": null | ||
| // } | ||
| const adminUser = adminUserFetchResult.data.id ? adminUserFetchResult.data : null | ||
| const apiUser = apiUserFetchResult.data.id ? apiUserFetchResult.data : null |
There was a problem hiding this comment.
I don't think this is the right way for us to be error checking. Is it possible to use SWR here? I can't recall what led to secureFetch being called here. No need to handle here, but please create an issue referencing this block so that we fix this (a comment like the one you've included should never really be necessary).
This PR introduces form validation for new API users using Formik and yup.
The PR also fixes #21 and removes an unwanted message shown when a new API user clicks
Create Account.