Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Groups July 2024 #1017

Open
wants to merge 19 commits into
base: dev-flex-2024
Choose a base branch
from

Conversation

miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Please explain the changes you made here and, if not immediately obvious from the code, how they resolve any referenced issues (and PRs if merging to master). Be sure to include all issues being resolved and any special configuration settings that are need for the software to run properly with these changes.

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Jul 11, 2024
@miles-grant-ibigroup miles-grant-ibigroup changed the base branch from dev to dev-flex-2024 July 11, 2024 18:43
@miles-grant-ibigroup miles-grant-ibigroup added WIP BLOCKED Blocked (waiting on another PR to be merged) Flex labels Jul 11, 2024
@clinephi
Copy link

Excited for this update!

@ibi-group ibi-group locked as too heated and limited conversation to collaborators Sep 12, 2024
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review September 17, 2024 14:36
onChange={(newValue) => this._onMinuteSecondInputChange(
newValue,
'flexDefaultZoneTime'
'defaultDwellTime'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where it happens in the code, but there is a layout glitch with dwell time:

image

@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants