Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Append Transformation #1009

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Add Append Transformation #1009

merged 1 commit into from
Apr 1, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Mar 21, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Blocked by ibi-group/datatools-server#592

Makes use of an as-of-yet unfinished backend PR to support append transformations. Uses the replace component for now. In future if we want to do column validation we can do it in a new component. Except how will we pull exactly the column order we need from the file that's getting appended to! yikes

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Mar 21, 2024
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review March 26, 2024 20:37
@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Mar 26, 2024
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Apr 1, 2024
@miles-grant-ibigroup miles-grant-ibigroup merged commit 1efb3f0 into dev Apr 1, 2024
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the add-append-transformation branch April 1, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @amy-corson-ibigroup