Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FeedUpdater): allow mongo query to use disk space #570

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(FeedUpdater): allow mongo query to use disk space #570

merged 1 commit into from
Oct 16, 2023

Conversation

philip-cline
Copy link
Contributor

@philip-cline philip-cline commented Oct 13, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

FeedUpdater mongo $group queries can get complicated quickly based on numbers of FeedVersions and are, by default, limited to 100MB of RAM. This PR allows the query that is failing due to memory limits to use disk space (temporary files) to finish the query.

miles-grant-ibigroup
miles-grant-ibigroup requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe make this conditional on how much disk space is available? I see disaster possible if there is low disk space

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved only for MTC

@philip-cline philip-cline merged commit 9027b28 into mtc-deploy Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@philip-cline philip-cline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philip-cline @binh-dam-ibigroup @miles-grant-ibigroup