Update validation language #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
binh-dam-ibigroup
approved these changes
Oct 13, 2023
| @@ -188,7 +188,7 @@ private static void validateTable( | |||
|
|
|||
| if (tableIsDirections && !gtfsRoutes.isEmpty()) { | |||
| // After we're done validating all the table values, check if every route was checked off in directions.txt | |||
| issues.add(new ValidationIssue(tableId, "route_id", -1, "Directions table does not define direction names for all routes.")); | |||
| issues.add(new ValidationIssue(tableId, null, -1, "Directions file doesn't define directions for all routes listed in routes file")); | |||
There was a problem hiding this comment.
Suggested change
| issues.add(new ValidationIssue(tableId, null, -1, "Directions file doesn't define directions for all routes listed in routes file")); | |
| issues.add(new ValidationIssue(tableId, null, -1, "The directions file doesn't define directions for all routes listed in the routes file")); |
or maybe say "routes listed in "routes.txt" explicitly.
There was a problem hiding this comment.
I like that better as well, I asked them what they think
There was a problem hiding this comment.
Alright we have the go-ahead for routes.txt which is my favourite
miles-grant-ibigroup
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Responding to some comments around the language of the recent
directions.txtvalidation.