Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex transformation updates #550

Merged
merged 31 commits into from
Oct 25, 2023
Merged

Flex transformation updates #550

merged 31 commits into from
Oct 25, 2023

Conversation

br648
Copy link
Contributor

@br648 br648 commented Jul 20, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Update to accommodate flex tables in transformations.

Robin Beer added 25 commits July 20, 2023 12:06
refactor(Update to various transform classes to accommodate flex):
3cff05e
refactor(EditorControllerTest.java): Changed feed source to one that …
47d1636 
…has less test data
refactor(Unit test and gtfs-lib update): Update to use refactored sto…
946461f 
…p time normalization (from gtfs
refactor(pom.xml): Reverted gtfs-lib back to latest dev-flex commit
368b98a
refactor(pom.xml): Changed gtfs-lib to reference latest stop times no…
70d9554 
…rmalization refactor
refactor(Test data update): Added missing commas to test data which w…
e0f19d3 
…as causing a unit test to not f
refactor(Updated unit test): Created distinct feed for normalizing fi…
c3a3a71 
…elds
refactor(Corrected feed config): Deleted stop areas and re-instated s…
379809c 
…top times
refactor(NormalizeFieldTransformJobTest.java): Refactored to create m…
dd91fb9 
…ultiple transformation type wit
refactor(Bumped gtfs lib to latest dev-flex version.): Updated test d…
efc0a40 
…ata for normalizing.
refactor(Added additional trips file): unit test failing validation b…
6ffa121 
…ecause of missing trips file
refactor(Reduce normalize fields unit test to just routes):
7a1f101
refactor(Re-instated areas and stop areas normalize field transformat…
3199283 
…ions):
refactor(NormalizeFieldTransformJobTest): Updated fields to be normal…
bfa99eb 
…ized. Removed stop areas becaus
refactor(Created separate feed source for normalizing field unit tests):
a42d8b6
refactor(Bug fixed and parameterized normalizing of field tests):
76a63e1
refactor(NormalizeFieldTransformJobTest): Changed back to using a sin…
ada194b 
…gle feed source.
refactor(NormalizeFieldTransformJobTest): Changed assertion.
fdac958
refactor(NormalizeFieldTransformJobTest): Added table name to feed so…
d0f5421 
…urce name
refactor(NormalizeFieldTransformJobTest): Changed test data to take c…
f768a78 
…aps into consideration
refactor(pom.xml): Bumped gtfs-lib version to stop time normalization…
4e8fa0c 
… refactor
refactor(pom.xml): Bumped gtfs lib to include stop times normalizatio…
8b8ddbb 
…n refactor with less logging
refactor(NormalizeFieldTransformJobTest): Restored correct feed sourc…
f503fae 
…e declaration
Fixed merge conflict
f1c65c2
refactor(Bumped GTFS-lib version): Version now matches the latest dev…
34545cb 
…-flex commit
philip-cline
philip-cline suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean fix, this is looking awesome! Thanks for setting this up. Just a couple of comments

src/main/java/com/conveyal/datatools/manager/jobs/ProcessSingleFeedJob.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/ProcessSingleFeedJob.java Outdated Show resolved Hide resolved
@philip-cline philip-cline assigned br648 and unassigned philip-cline Aug 30, 2023
@br648 br648 assigned philip-cline and unassigned br648 Sep 1, 2023
@br648 br648 requested a review from philip-cline September 6, 2023 10:05
@philip-cline philip-cline assigned br648 and unassigned philip-cline Sep 27, 2023
@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Sep 28, 2023
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, see the few nice-to-have tweaks. repo.opengeo.org is not responsive at the moment, and I am not able to download dependencies, but I'm going to approve anyway.

src/main/java/com/conveyal/datatools/manager/jobs/ProcessSingleFeedJob.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/models/transform/NormalizeFieldTransformation.java Outdated Show resolved Hide resolved
src/test/java/com/conveyal/datatools/manager/jobs/ProcessSingleFeedJobNotificationTest.java Outdated Show resolved Hide resolved
src/test/java/com/conveyal/datatools/manager/jobs/ProcessSingleFeedJobNotificationTest.java Outdated Show resolved Hide resolved
src/test/java/com/conveyal/datatools/manager/jobs/NormalizeFieldTransformJobTest.java Outdated Show resolved Hide resolved
@br648 br648 merged commit 128f14d into dev-flex Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@br648 @binh-dam-ibigroup @philip-cline