-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed Source Summary #529
Feed Source Summary #529
Conversation
… has a pinned deployment and re
@br648 I think the main bottleneck is that the same query is still repeated for each project, and as a result, the number of times we hit Mongo doesn't change overall. Could you see what happens if |
…ailable via a new end point
@philip-cline I've made an update to include feed source label ids. The latest feed version should already be available as part of the information returned by feedsourceSummaries. To keep the payload to a minimum, only the required values from the latest feed version are returned. See |
@br648 Would it be easy to include |
@philip-cline I have added the project id to the feed source summary. |
It seems like it will be easier on the front end to integrate these changes if we maintain some of the same structure as previous. Could we use the following structure:
|
…ion result): This new class ali
@philip-cline Structure updated as requested. |
Thanks for the update @br648! I just made another small commit changing the field names so that they require less work on the front end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me! I have been able to create a front end PR to test it out and works well!
…s://github.com/ibi-group/datatools-server into feature/DT-315-Speed-up-feed-version-retrieval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inclined to approve, as the loading is much faster with the UI PR, but I would make sure labelIds
is non-null.
Checklist
dev
before they can be merged tomaster
)Description
Update to provide a new end point which will return all feed source summaries as required by the UI.
Companion PR: ibi-group/datatools-ui#981
See: https://ibisolutions.atlassian.net/browse/DT-315?focusedCommentId=251321