Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8657: Reworked CDP security layer to not rely on deprecated guard authenticators #136

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Aug 14, 2024

🎫 Issue IBX-8657

Related PRs:

Description:

This time changes are pretty simple - we only replace deprecated guard configuration key with our own, adjusted CDP authenticator implementation.

For QA:

The whole flow related to integration with CDP needs to be verified.

Documentation:

Config change.

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-136

before executing the recipes.

@konradoboza konradoboza self-assigned this Aug 14, 2024
@konradoboza konradoboza changed the title IBX-8657: Reworked security layer to not rely on deprecated guard authenticators IBX-8657: Reworked CDP security layer to not rely on deprecated guard authenticators Aug 14, 2024
@konradoboza konradoboza marked this pull request as ready for review August 19, 2024 09:56
@konradoboza konradoboza added Doc needed The changes require some documentation Ready for review labels Aug 19, 2024
@konradoboza konradoboza requested a review from a team August 19, 2024 10:15
@Steveb-p Steveb-p requested a review from a team August 19, 2024 10:51
Copy link

@konradoboza konradoboza requested a review from Steveb-p August 19, 2024 13:49
@Steveb-p Steveb-p requested a review from a team August 19, 2024 13:56
@konradoboza
Copy link
Contributor Author

Merging as it's required by already merged ibexa/cdp counterpart PR.

@konradoboza konradoboza merged commit 1a4333f into master Aug 20, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8657-reworked-cdp-security branch August 20, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants