Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8656: Reworked OAuth2 client authentication to comply with new Symfony security #133

Merged
merged 3 commits into from
Aug 14, 2024
Merged

IBX-8656: Reworked OAuth2 client authentication to comply with new Symfony security #133

merged 3 commits into from
Aug 14, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Jul 29, 2024 •
edited
Loading

🎫 Issue IBX-8656

Related PRs:

Description:

Changes in the OAuth2 client firewall configuration are mostly a natural consequence of:

security:
    enable_authenticator_manager: true

which we enabled in the beginning. Related PRs explain in more details how the deprecated guard authenticator-based security was redone.

For QA:

Documentation:

@github-actions GitHub Actions
Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-133

before executing the recipes.

@konradoboza konradoboza mentioned this pull request Aug 2, 2024
Merged
@konradoboza konradoboza marked this pull request as ready for review August 2, 2024 07:32
@konradoboza konradoboza added Ready for review Doc needed The changes require some documentation labels Aug 2, 2024
@konradoboza konradoboza requested a review from a team August 2, 2024 08:14
@adamwojs adamwojs requested a review from a team August 5, 2024 07:32
@konradoboza konradoboza requested review from Steveb-p, adamwojs and a team August 5, 2024 08:22
@konradoboza konradoboza requested a review from a team August 5, 2024 08:23
@alongosz alongosz requested a review from a team August 5, 2024 10:18
@konradoboza konradoboza force-pushed the ibx-IBX-8656-reworked-oauth2-authorization branch 2 times, most recently from 41059b6 to 8d72e69 Compare August 14, 2024 10:53
@konradoboza konradoboza mentioned this pull request Aug 14, 2024
Closed
@konradoboza konradoboza changed the title IBX-8656: Reworked OAuth2 client authentication to comply with new Symfony security [DO NOT MERGE - TMP COMMIT] IBX-8656: Reworked OAuth2 client authentication to comply with new Symfony security Aug 14, 2024
@konradoboza konradoboza force-pushed the ibx-IBX-8656-reworked-oauth2-authorization branch from 8d72e69 to 2c2cae2 Compare August 14, 2024 11:31
tomaszszopinski
tomaszszopinski approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 5.0 commerce.

@konradoboza konradoboza changed the title [DO NOT MERGE - TMP COMMIT] IBX-8656: Reworked OAuth2 client authentication to comply with new Symfony security IBX-8656: Reworked OAuth2 client authentication to comply with new Symfony security Aug 14, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza merged commit 8a7c7ef into master Aug 14, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-IBX-8656-reworked-oauth2-authorization branch August 14, 2024 12:48
@mnocon mnocon removed the Doc needed The changes require some documentation label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@alongosz alongosz alongosz approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees
No one assigned
Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradoboza @adamwojs @Steveb-p @Nattfarinn @alongosz @tomaszszopinski @mnocon