Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue resulting from a conflict in block reference #327

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Fix issue resulting from a conflict in block reference #327

merged 4 commits into from
Jan 27, 2025

Conversation

dabrt
Copy link
Contributor

@dabrt dabrt commented Jan 27, 2025 •
edited by adriendupuis
Loading

adriendupuis
adriendupuis requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@adriendupuis adriendupuis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep "Number of visible products" and "Stock threshold" labels.
Their descriptions also seem more detailed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dabrt dabrt merged commit 8c782ba into 4.6 Jan 27, 2025
6 checks passed
@dabrt dabrt deleted the dabrt-patch-1 branch January 27, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriendupuis adriendupuis adriendupuis approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

Assignees
No one assigned
Labels
Needs DOC review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabrt @adriendupuis @julitafalcondusza