Skip to content

Enhance preview comment #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 4.6
Choose a base branch
from
Open

Enhance preview comment #2769

wants to merge 7 commits into from

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Jun 5, 2025 •
edited
Loading

Question Answer
JIRA Ticket
Versions 4.6, 5.0
Edition
  • Sort PHP API Reference links (this mixes namespaces and classes but help navigation as in a tree).
  • If there is too many links, remove namespaces and retry.
  • Output link list to stdout so it's available in GitHub action report even if the limit is reached and the PR comment skipped.
  • Fix "greater than" HTML entity.
  • Better \E (ESC control character) bug fix.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis changed the base branch from 5.0 to 4.6 June 5, 2025 09:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2025 •
edited
Loading

Preview of modified files: no change to preview.

@adriendupuis adriendupuis mentioned this pull request Jun 5, 2025
Closed
7 tasks
@adriendupuis adriendupuis marked this pull request as ready for review June 5, 2025 13:23
@adriendupuis adriendupuis requested a review from mnocon June 5, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon Awaiting requested review from mnocon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adriendupuis