Skip to content

IBX-10167: Fixed translations export in abstract field type classes #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Jun 25, 2025

🎫 Issue IBX-10167

Description:

It seems like JMS\TranslationBundle\Translation\Extractor\File\TranslationContainerExtractor doesn't work well with abstract classes that are part of the TranslationContainerInterface interface:

In TranslationContainerExtractor.php line 112:
                                                                                                                                                      
  call_user_func(): Argument #1 ($callback) must be a valid callback, cannot call abstract method Ibexa\Core\FieldType\BaseNumericType::getTranslati  
  onMessages()

therefore I moved the interface into concrete classes.

For QA:

Documentation:

@barw4 barw4 self-assigned this Jun 25, 2025
@barw4 barw4 added Bug Something isn't working Ready for review labels Jun 25, 2025
@barw4 barw4 force-pushed the ibx-10167-fix-translation-export branch from c5d3bd7 to 64c2ed3 Compare June 25, 2025 07:44
Copy link

@barw4 barw4 requested a review from a team June 25, 2025 08:19
@ezrobot ezrobot requested review from adamwojs, mikadamczyk, Steveb-p, alongosz, ciastektk, ViniTou and wiewiurdp and removed request for a team June 25, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants