Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7792: The modal was adapted to the new schema, jQuery dependencies were removed #9

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Feb 19, 2024
@mateuszdebinski mateuszdebinski requested a review from a team February 19, 2024 14:33
@mateuszdebinski mateuszdebinski self-assigned this Feb 19, 2024
@GrabowskiM GrabowskiM requested a review from a team February 28, 2024 13:32
@mateuszdebinski mateuszdebinski force-pushed the IBX-7792_cant_select_source_language branch from a7f668e to 4a779c0 Compare March 5, 2024 15:47
@mateuszdebinski mateuszdebinski requested review from GrabowskiM and a team March 5, 2024 15:47
@mateuszdebinski mateuszdebinski force-pushed the IBX-7792_cant_select_source_language branch from 4a779c0 to 08e9613 Compare March 5, 2024 15:53
@konradoboza konradoboza requested a review from ciastektk March 12, 2024 10:57
@mateuszdebinski mateuszdebinski force-pushed the IBX-7792_cant_select_source_language branch 2 times, most recently from 7c8447c to 7a34cd0 Compare March 18, 2024 14:32
@mateuszdebinski mateuszdebinski force-pushed the IBX-7792_cant_select_source_language branch from 7a34cd0 to 1c6a46f Compare March 18, 2024 14:34
@mateuszdebinski mateuszdebinski force-pushed the IBX-7792_cant_select_source_language branch from 1c6a46f to b5764ba Compare March 18, 2024 14:38
@micszo micszo self-assigned this Mar 27, 2024
@micszo
Copy link

micszo commented Mar 28, 2024

Please see: https://recordit.co/zAn4cm11Ux

When opening "Create a new translation" pop-up, after refreshing the page, select translation service dropdown is active with "No language" selected as source language. Which can lead to an error in the next step.

The same occurs when pop-up is opened for the first time for given content item (Dropdown is deactivated when "No language" is selected for the first time).

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.5.7-dev.

@micszo micszo removed their assignment Mar 29, 2024
@dew326 dew326 merged commit 9c29045 into 4.5 Mar 29, 2024
3 checks passed
@dew326 dew326 deleted the IBX-7792_cant_select_source_language branch March 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants