Add Japanese to list of supported languages for DeepL #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this list is from an earlier time, but Japanese is supported by DeepL and this adds it to the constants. Maybe this list should be either dynamically updated or moved to a configuration?
janit
changed the title
konradoboza
reviewed
Jun 6, 2024
Locale used by DeepL is actually JA (not JP as originally). In addition fixed whitespace nitpick
Seems like the `/v1/` API endpoint no longer works, but `/v2/` seems to be close enough for this extension to works.
|
konradoboza
approved these changes
Jun 7, 2024
mikadamczyk
approved these changes
Jun 7, 2024
adamwojs
approved these changes
Jun 22, 2024
|
Thank you @janit for contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this list is from an earlier time, but Japanese is supported by DeepL and this adds it to the constants.
Maybe this list should be either dynamically updated or moved to a configuration?