Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Tab API phpdoc #986

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Improved Tab API phpdoc #986

merged 2 commits into from
Nov 15, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Nov 15, 2023 •
edited
Loading

Question Answer
Tickets N/A
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Improved phpdoc in Ibexa\Contracts\AdminUi\Tab namespace:

  • Removed redundant phpdocs
  • Fixed typos
  • Added mode specific $parameters type

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs requested a review from a team November 15, 2023 04:54
@konradoboza konradoboza requested a review from a team November 15, 2023 07:48
@mikadamczyk mikadamczyk requested a review from a team November 15, 2023 07:55
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx merged commit fe91a44 into main Nov 15, 2023
@webhdx webhdx deleted the improved_tabs_phpdoc branch November 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@ciastektk ciastektk ciastektk approved these changes

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamwojs @mikadamczyk @ciastektk @webhdx @konradoboza @Nattfarinn @ViniTou