IBX-8707: Items listed in role assignment page are not clickable #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidarl
force-pushed
the
IBX-8707_Items_listed_in_role_assignment_page_are_not_clickable
branch
3 times, most recently
from
ee48c9e to
c7fed2d
Compare
adamwojs
reviewed
Apr 7, 2025
src/bundle/Resources/views/themes/admin/user/role_assignment/list.html.twig
Outdated
Show resolved
Hide resolved
OstafinL
approved these changes
Apr 10, 2025
dew326
approved these changes
Apr 10, 2025
RopRaptor
approved these changes
Apr 10, 2025
tischsoic
reviewed
Apr 10, 2025
src/bundle/Resources/views/themes/admin/user/role_assignment/list.html.twig
Outdated
Show resolved
Hide resolved
|
FYI : CI now fails, but that is not related to my changes |
barbaragr
force-pushed
the
IBX-8707_Items_listed_in_role_assignment_page_are_not_clickable
branch
from
dcd48db to
c9e8a76
Compare
PHPStan remarks have to addressed before merging anyway. 😉 |
|
CI needs to be unblocked before QA can proceed. Disabled jobs can mask potential issues. |
adamwojs
force-pushed
the
IBX-8707_Items_listed_in_role_assignment_page_are_not_clickable
branch
from
c9e8a76 to
3b2087d
Compare
|
|
I've rebased PR and QA should be unblocked now.
"It's none of my business" it not a a mindset we are practicing at Ibexa. Next time, please open PR or notify maintainers of a given repository about the fact. // cc @micszo @vidarl |
barbaragr
approved these changes
Apr 28, 2025
adamwojs
deleted the
IBX-8707_Items_listed_in_role_assignment_page_are_not_clickable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make rows in Role assignment tab as clickable links