IBX-9448: Input side label #1432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozatko
approved these changes
Jan 30, 2025
lucasOsti
requested changes
Jan 30, 2025
GrabowskiM
approved these changes
Jan 30, 2025
GrabowskiM
approved these changes
Jan 30, 2025
Comment on lines
+69
to
+70
| {% block right_side_label %} | ||
| {% if right_side_label is defined %} |
There was a problem hiding this comment.
I'm no expert in twig, but isn't here some potential problems in using same name for both variable and block name?
tischsoic
force-pushed
the
feature-discount
branch
from
4355ebf to
b123a8b
Compare
tischsoic
force-pushed
the
IBX-9448-percentage-label
branch
from
9d42a16 to
2377cdc
Compare
|
GrabowskiM
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: