Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9374: stored copied link clipboard #1431

Merged
merged 2 commits into from
Feb 10, 2025
+55 −84
Merged

IBX-9374: stored copied link clipboard #1431

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8cc63
IBX-9374: stored copied link clipboard
OstafinL Jan 29, 2025
33caed6
After CR - added tooltip-variant mixin
OstafinL Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
IBX-9374: stored copied link clipboard
@OstafinL
OstafinL committed Jan 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 0b8cc63ddd587cef7ed4d047a56bed684c08b93a
48 changes: 48 additions & 0 deletions src/bundle/Resources/public/scss/_custom.tooltip.scss
View file
Original file line number Diff line number Diff line change
@@ -62,6 +62,54 @@
box-shadow: 0 calculateRem(4px) calculateRem(6px) rgba(135, 135, 135, 0.35);
}

&--dark {
.ibexa-tooltip {
&__inner {
color: $ibexa-color-white;
background-color: $ibexa-color-dark;
Copy link
Contributor

@GrabowskiM GrabowskiM Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't be cruel to you as there are other modifiers already, but I think we should consider using either mixin or (perhaps better) css variables for these colors so that you could do just

--dark {
  --ibexa-tooltip-bg-color: $ibexa-color-dark;
}

to add new type of tooltip

border-color: transparent;
}
}

&.ibexa-tooltip {
&.bs-tooltip-top,
&[data-popper-placement='top'] {
.ibexa-tooltip__arrow {
&::before {
border-top-color: $ibexa-color-dark;
}
}
}

&.bs-tooltip-end,
&[data-popper-placement='right'] {
.ibexa-tooltip__arrow {
&::before {
border-right-color: $ibexa-color-dark;
}
}
}

&.bs-tooltip-bottom,
&[data-popper-placement='bottom'] {
.ibexa-tooltip__arrow {
&::before {
border-bottom-color: $ibexa-color-dark;
}
}
}

&.bs-tooltip-start,
&[data-popper-placement='left'] {
.ibexa-tooltip__arrow {
&::before {
border-left-color: $ibexa-color-dark;
}
}
}
}
}

&--ground-dark {
.ibexa-tooltip {
&__inner {