Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9358 Fixed discard button in number input #1425

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

IBX-9358 Fixed discard button in number input #1425

wants to merge 1 commit into from

Conversation

bozatko
Copy link
Contributor

@bozatko bozatko commented Jan 17, 2025

🎫 Issue IBX-9358

Description:

For QA:

Documentation:

GrabowskiM
GrabowskiM approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully convinced to it, as now you totally ignore extra actions btns in number fields, probably ok for now as we don't have such places, but sooner or later it'll bite us :)

@pawlakadrian pawlakadrian self-assigned this Jan 29, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pawlakadrian
Copy link

QA approved on IbexaDXP 4.6 commerce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@dew326 dew326

@pawlakadrian pawlakadrian

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bozatko @pawlakadrian @GrabowskiM @tischsoic @dew326 @lucasOsti