Skip to content

IBX-9333: introduced isUpdate to reload sub-items page after actions #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

IBX-9333: introduced isUpdate to reload sub-items page after actions #1419

merged 1 commit into from
Feb 19, 2025

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Jan 14, 2025 •
edited
Loading

🎫 Issue IBX-9333

Description:

After introducing requestParamsHaveChanged, actions did not cause the page to be reloaded and the loading to be hidden, which is why an additional state was introduced

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jan 14, 2025
@mateuszdebinski mateuszdebinski requested a review from a team January 14, 2025 09:48
@mateuszdebinski mateuszdebinski self-assigned this Jan 14, 2025
@mateuszdebinski mateuszdebinski force-pushed the IBX-9333_Sub-items_list_endless_loading branch from 1f483a9 to e5c366f Compare January 14, 2025 09:51
@mateuszdebinski mateuszdebinski requested a review from a team January 23, 2025 14:50
@KamilSznajdrowicz KamilSznajdrowicz force-pushed the IBX-9333_Sub-items_list_endless_loading branch from e5c366f to e886084 Compare February 5, 2025 11:01
@KamilSznajdrowicz KamilSznajdrowicz mentioned this pull request Feb 5, 2025
Closed
KamilSznajdrowicz

This comment was marked as outdated.

Sign in to view

@KamilSznajdrowicz KamilSznajdrowicz self-requested a review February 5, 2025 14:19
KamilSznajdrowicz
KamilSznajdrowicz requested changes Feb 5, 2025
View reviewed changes
Copy link

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked, and the priorities are fine, but there's still the issue of deleting and hiding

hide.delete.mov

@vidarl
Copy link
Contributor

vidarl commented Feb 6, 2025 •
edited
Loading

I also still have the same problem when moving subitems

@KamilSznajdrowicz
Copy link

Add locations and reveal also.

@mateuszdebinski mateuszdebinski force-pushed the IBX-9333_Sub-items_list_endless_loading branch from e886084 to 6816431 Compare February 14, 2025 10:37
@mateuszdebinski mateuszdebinski changed the title IBX-9333: introduced isPriorityUpdate to reload sub-items page after priority update IBX-9333: introduced isUpdate to reload sub-items page after actions Feb 14, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
39.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@KamilSznajdrowicz KamilSznajdrowicz mentioned this pull request Feb 19, 2025
Closed
KamilSznajdrowicz
KamilSznajdrowicz approved these changes Feb 19, 2025
View reviewed changes
Copy link

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tested on 4.6.x-dev, patch applied and successfully tested on v4.6.16

@dew326 dew326 merged commit 9c7452c into 4.6 Feb 19, 2025
30 of 31 checks passed
@dew326 dew326 deleted the IBX-9333_Sub-items_list_endless_loading branch February 19, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@KamilSznajdrowicz KamilSznajdrowicz KamilSznajdrowicz approved these changes

@albozek albozek albozek approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

@OstafinL OstafinL Awaiting requested review from OstafinL

Assignees

@dew326 dew326

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszdebinski @vidarl @KamilSznajdrowicz @GrabowskiM @dew326 @albozek