IBX-9227: Restore multipleItemsLimit cehcks in UDW

[tischsoic]

🎫 Issue	IBX-9227

Related PRs:

• https://github.com/ibexa/image-picker/pull/94

Description:

For QA:

Documentation:

[tischsoic]

Note: I created a hook which wraps helpers so that instead of having to do something like this:

import { checkIsSelectable, checkIsSelected, checkIsSelectionBlocked } from '../../helpers/locations.helper';
import {
    ContentTypesMapContext,
    SelectedLocationsContext,
    MultipleConfigContext,
    ContainersOnlyContext,
    AllowedContentTypesContext,
} from '../../universal.discovery.module';

const contentTypesMap = useContext(ContentTypesMapContext);
const [selectedLocations] = useContext(SelectedLocationsContext);
const [multipleItemsLimit] = useContext(MultipleConfigContext);
const containersOnly = useContext(ContainersOnlyContext);
const allowedContentTypes = useContext(AllowedContentTypesContext);
const isSelected = checkIsSelected({ location, selectedLocations });
const isNotSelectable = !checkIsSelectable({ location, contentTypesMap, allowedContentTypes, containersOnly });
const isSelectionBlocked = checkIsSelectionBlocked({ location, selectedLocations, multipleItemsLimit });

we can do:

import { useSelectedLocationsHelpers } from '../../hooks/useSelectedLocationsHelpers';

const { checkIsSelectable, checkIsSelected, checkIsSelectionBlocked } = useSelectedLocationsHelpers();
const isSelected = checkIsSelected(location);
const isNotSelectable = !checkIsSelectable(location);
const isSelectionBlocked = checkIsSelectionBlocked(location);

[lucasOsti]

I would prefer to remove the word Helper from useSelectedLocationsHelpers because at the hooks directory level we have a helpers directory with helpers and this can be confusing

[GrabowskiM]

I agree with Łukasz, I think Helper isn't even needed

[tischsoic]

I think that naming this hook useSelectedLocations would be more confusing because with such a name I would expect that the hook would return data about selected locations. But instead, it returns helpers so I think that useSelectedLocationsHelpers precisely says what we have here and removing Helpers from its name would make it more confusing.

[GrabowskiM]

I have small issue with Wrapped, with current name it can be read as check if IsSelectable wrapped
maybe cachedCheckIsSelectable, or more complex

import { checkIsSelectable: checkIsSelectableHelper } from '../helpers/selected.locations.helper';

...

const checkIsSelectableWrapped = useCallback(
    (location) => checkIsSelectableHelper({ location, contentTypesMap, allowedContentTypes, containersOnly }),
    [contentTypesMap, allowedContentTypes, containersOnly],
);

[tischsoic]

I would disagree about cached because there is nothing about caching here, but about wrapping the original helper function so that some parameters are provided by the hook. We can remove useCallback here and the hook would still be valid.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tischsoic]

Merged up:

• main: fa04ad4