IBX-9086 Autogenerated identifiers for content types & field definitions #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozatko
force-pushed
the
IBX-9086-autogenerated-identifiers
branch
from
bcf1fab to
b35591b
Compare
lucasOsti
requested changes
Nov 5, 2024
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
dew326
requested changes
Nov 5, 2024
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/field_definition.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/create.html.twig
Outdated
Show resolved
Hide resolved
|
Note: Broken behat tests probably are related to changes in the PR. Tests should be adapted to new behavior. |
dew326
requested changes
Nov 6, 2024
src/bundle/Resources/public/js/scripts/autogenerate.identifier.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/autogenerate.identifier.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/autogenerate.identifier.js
Outdated
Show resolved
Hide resolved
dew326
reviewed
Nov 6, 2024
src/bundle/Resources/public/js/scripts/autogenerate.identifier.js
Outdated
Show resolved
Hide resolved
lucasOsti
approved these changes
Nov 7, 2024
src/bundle/Resources/public/js/scripts/autogenerate.identifier.js
Outdated
Show resolved
Hide resolved
dew326
force-pushed
the
IBX-9086-autogenerated-identifiers
branch
from
94565f7 to
27ff2b2
Compare
dew326
approved these changes
Nov 7, 2024
GrabowskiM
approved these changes
Nov 8, 2024
|
KamilSznajdrowicz
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: