IBX-9169: Enable searching by content's name in the Trash

[barw4]

🎫 Issue	IBX-9169

Related PRs:

ibexa/core#448

Description:

[ViniTou]

However, as I understand why and this beeing low cost - question is should it just target 5.0 to be rules obidient.

[barw4]

@ViniTou it's highly requested unfortunately lately so I think we need to bend the rules a bit here

[adamwojs]

It's a really great feature! I think we should switch the position of "Content name" and "Creator" fields as well as remove "Content name" label to align filters in trash to design system, for example:

[barw4]

@adamwojs done, please see the ticket's description for updated looks

[katarzynazawada]

A few improvements are needed:

1. Label and placeholder for creator filter should be different, using Search by creator gives the impression that two searches are available. We can use the same as in global search (consulted with @juskora):

2. Missing search button

3. Clicking X button in input field should reload the page.
4. Entering only the beginning of the name of the content into the search does not find the content, e.g. trash for trashtest. It is inconsistent with the rest of the search in the system (apart from global search, which works differently).
5. When the search criteria are not met another empty state is needed as in other places
   Justyna's recommendation:

Sorry, there are no contents for your search
Try again with new search criteria.

6. The list header should be different after the search Results for "xxx"(x), e.g.

7. Typing * in search returns all contents.

8. This may be a little out of the scope of the task, but it may be worthwhile on this occasion to align this list with the others in the system and add an Apply and Clear filters button. See please: https://www.figma.com/design/4sbNQyNLhFFwxWDH89Rf9X/🟢-%5BIbexa%5D-Design-System?node-id=2814-93260&node-type=frame&t=q0HqwddEw9pvhEzI-0

[adamwojs]

@barw4 Could you please apply @katarzynazawada suggestions ?

[barw4]

@katarzynazawada @adamwojs

1. done
2. done
3. done
4. Not possible with the current criterion implementation. Content name searching works in the same way as the main content search and implementing a new criterion seems like an overkill.
5. done
6. This is easily doable for a list that has only a single filter like attribute groups but for a list that has multiple filters it's not so straightforward. If you have selected 3 filters, which one will you show? All of them? First one? For example, payment methods have also a constant header. done
7. It's the same criterion as in global content search, I'm not sure there is much we can do here without introducing a completely new criterion (please see 4.)
8. The issue is we are using an old date picker here and it's simply not compatible with the new adaptive filters. We could replace it but it will take a bit of time so I'm not sure it's worth it right now

[katarzynazawada]

This is easily doable for a list that has only a single filter like attribute groups but for a list that has multiple filters it's not so straightforward. If you have selected 3 filters, which one will you show? All of them? First one? For example, payment methods have also a constant header.

@barw4 Payment methods have a constant header but it's a bug 🙂 See please: https://issues.ibexa.co/browse/IBX-5593
Expected result from the ticket: Depending on criteria we should end up with "List" for none selected, "Results" for filtering and "Result for [phrase]" for search.

[barw4]

@katarzynazawada thank you for the explanation, fixed.

[katarzynazawada]

1. 500 error when using pagination in the trash

2. Empty state for searching is not fully correct.
   Try again with new search criteria. is missing below Sorry, there are no contents for your search

Screenshot from catalog for comparison.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud