IBX-9056: Redesigned content preview #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozatko
force-pushed
the
IBX-9056-redesign-content-preview
branch
from
3441d4d to
937b7a8
Compare
bozatko
force-pushed
the
IBX-9056-redesign-content-preview
branch
from
937b7a8 to
62bcebd
Compare
dew326
requested changes
Oct 29, 2024
lucasOsti
requested changes
Oct 29, 2024
GrabowskiM
requested changes
Oct 29, 2024
dew326
approved these changes
Oct 30, 2024
lucasOsti
approved these changes
Oct 30, 2024
GrabowskiM
approved these changes
Oct 31, 2024
KamilSznajdrowicz
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Hi :)
I found some bugs
- The selected item (site) from the dropdown is not visible.
- The dropdown should not have a border, according to the design.
- The close button is too large.
- The page content element is rounded, but it shouldn't be according to the Figma design.
- The separating line between the dropdown and the device view is missing ( according to the Figma design)
dew326
requested changes
Nov 8, 2024
src/bundle/Resources/views/themes/admin/content/content_preview.html.twig
Outdated
Show resolved
Hide resolved
dew326
approved these changes
Nov 18, 2024
KamilSznajdrowicz
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Hi :) I found two more bugs:
- According to the design:
In addition to the site name that we display, we should also show a globe icon and the label 'Site: '.
Now:
- The arrow next to the site dropdown in the design is white, but on our side, it is gray. Here, we should implement a hover effect similar to the one used for device selection to ensure consistency.
|
@KamilSznajdrowicz we will not introduce here "site context switcher" as this is separate package and we cannot use it here. |
KamilSznajdrowicz
force-pushed
the
IBX-9056-redesign-content-preview
branch
from
b5febe4 to
2b37de5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: