Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require_oauth decorator was always succeeding. #5

Merged
merged 1 commit into from
Apr 6, 2013

Conversation

datalogics-kam
Copy link
Contributor

verify_request() returns a tuple of (valid, oauth_request). The code was
treating it as if it returned just a bool, and since the never-empty
tuple was always truthy, requests always seemed to work.

Fixes ib-lundgren/flask-oauthprovider/#3

verify_request() returns a tuple of (valid, oauth_request). The code was
treating it as if it returned just a bool, and since the never-empty
tuple was always truthy, requests always seemed to work.

Fixes ib-lundgren/flask-oauthprovider/ib-lundgren#3
@ib-lundgren
Copy link
Owner

Thanks for the PR and sorry for the late reply. Ideally the unpacking would be done directly rather than unpacking but that's just details. Merging.

valid, oauth_request  = self.verify_request(...

ib-lundgren added a commit that referenced this pull request Apr 6, 2013
require_oauth decorator was always succeeding.
@ib-lundgren ib-lundgren merged commit e671925 into ib-lundgren:master Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants