Fix: Ensure block transformation works in the example #5803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the current example for toggling a code block using the backtick key doesn't work as expected. The issue occurs because
Editor.nodes()
can return text nodes instead of block elements, causingTransforms.setNodes()
to fail.To fix this, I added an extra check using
Element.isElement(n)
, ensuring that only block elements are transformed.Issue
Slate docs - Applying Custom Formatting
Example
Before the fix:
Pressing the backtick key sometimes fails to toggle a code block due to Transforms.setNodes() being applied to text nodes - demo.
After the fix:
The backtick key now correctly toggles a code block, as the logic ensures only block elements are transformed - demo
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)