Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: add change.snapshotSelection in the change.md #1534

Merged
merged 2 commits into from
Jan 17, 2018

Conversation

zhujinxuan
Copy link
Contributor

Hi, I think change.snapshotSelection is useful in developing some packages with removeNode, for example, in the case of GitbookIO/slate-edit-table#40

Therefore, I think it might be better if we have list the api in the document.

@schneidmaster
Copy link
Collaborator

@zhujinxuan Thanks for the PR! Sorry to nitpick -- would you mind inserting a newline between lines 480 and 481, and capitalizing "snapshot" in the following sentence? That should make the new entry match the rest of the documentation format 👍

screenshot 2018-01-16 22 40 37

@zhujinxuan
Copy link
Contributor Author

@schneidmaster Thank you. updated~

@schneidmaster schneidmaster merged commit e6c7934 into ianstormtaylor:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants