fix: ignore fields that don't have an ssm tag #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlopshire
approved these changes
Oct 9, 2023
|
@ianlopshire thank you for approving and merging this. Do you plan to make a release tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I process my struct with kelseyhightower/envconfig before passing it to go-ssm-config. The problem with that is any field that has a
defaulttag but nossmis overwritten with the specified default value. I would like go-ssm-config to skip any field that doesn't have anssmtag so the value obtained from envconfig is retained. This PR fixes this behavior as documented in the README: