update to appropriately write lists out to the vault secret object #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you attempt to write out a list as a value into vault the writer will incorrectly format the list
example
This is fairly annoying and can be worked-around but it's not the behavior I was expecting. My work-around for this currently is just to use a comma-separated list but it's not ideal. Explicitly using a
JsonArray
object works but then I have issues when using jackson to convert objects and need special work-arounds just for writing a map to vault.This change will convert any list objects into
JsonArray
objects to make using this library a bit simpler and straight foward. I didn't see any tests for theLogical
class so i made a quick unit test to show it's working. I've tested this locally for my user-case and it seems to do the trick.