Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to appropriately write lists out to the vault secret object #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kmcgovern-apixio
Copy link

Currently when you attempt to write out a list as a value into vault the writer will incorrectly format the list

example

{
   "key": "[value1, value2]"
}

This is fairly annoying and can be worked-around but it's not the behavior I was expecting. My work-around for this currently is just to use a comma-separated list but it's not ideal. Explicitly using a JsonArray object works but then I have issues when using jackson to convert objects and need special work-arounds just for writing a map to vault.

This change will convert any list objects intoJsonArray objects to make using this library a bit simpler and straight foward. I didn't see any tests for the Logical class so i made a quick unit test to show it's working. I've tested this locally for my user-case and it seems to do the trick.

@ianferguson
Copy link
Owner

👋 sorry I missed this when you opened it -- at this point I'm not planning on maintaining this library or working on adding additional changes beyond the X-Vault-Request header support that was added when this forked from the upstream https://github.com/bettercloud/vault-java-driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants