Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export-element): fallback to export as image when window open is not supported #1269

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

iamogbz
Copy link
Owner

@iamogbz iamogbz commented Dec 22, 2024

Description

Fallback when allow-popup, allow-download is disabled on browser

  • Makes image download a clickable link
  • Clear up image memory url when modal is closed
  • Add keyboard esc listener to dismiss capture

Checklist

  • This PR has updated documentation
  • This PR has sufficient testing

Comments

N/A

@iamogbz iamogbz changed the title fix: fallback to export as image when window open is not supported fix(export-element): fallback to export as image when window open is not supported Dec 22, 2024
@iamogbz iamogbz merged commit afa2442 into main Dec 22, 2024
3 checks passed
@iamogbz iamogbz deleted the fix-frame-fallback branch December 22, 2024 19:58
iamogbz pushed a commit that referenced this pull request Dec 22, 2024
## [1.5.2](v1.5.1...v1.5.2) (2024-12-22)

### Bug Fixes

* **export-element:** fallback to export as image when window open is not supported ([#1269](#1269)) ([afa2442](afa2442))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant