Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync jdf Sample #20

Merged
merged 24 commits into from
Jul 6, 2022
Merged

Conversation

KyleKing
Copy link
Contributor

@KyleKing KyleKing commented May 22, 2022

The sample LaTeX file has diverged from the Google Doc and along with the content changes, a few minor fixes were necessary to bring them back into sync.

Fixes: #6, #18

Includes changes from other open PRs #15, #17, and #12/#19 (so that this fork can be used standalone)

Additionally, the Overleaf template should be updated (and linked from the Documentation somewhere): https://www.overleaf.com/latex/templates/joyner-document-format-v2-dot-2/xysfjgnvxnqq

This PR would have helped save a peer time by offering a fixed figure that better follows the user's mental model with jdffigure (https://edstem.org/us/courses/22239/discussion/1599685)

Note: I haven't updated or tested the pandoc, RMarkdown, or Pages templates

@KyleKing KyleKing marked this pull request as draft May 22, 2022 10:24
@KyleKing KyleKing marked this pull request as ready for review May 22, 2022 17:48
@iamjakewarner iamjakewarner merged commit abb3065 into iamjakewarner:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package biblatex Warning: Field 'prefixnumber' deprecated. Please use 'labelprefix' instead.
5 participants