Skip to content

Commit

Permalink
scripts: add spdxcheck.py self test
Browse files Browse the repository at this point in the history
Add a script that will run spdxcheck.py through a couple of self tests to
simplify validation in the future.  The tests are run for both Python 2
and Python 3 to make sure all changes to the script remain compatible
across both versions.

The script tests a regular text file (Makefile) for basic sanity checks
and then runs it on a binary file (Documentation/logo.gif) to make sure it
works in both cases.  It also tests opening files passed on the command
line as well as piped files read from standard input.  Finally a run on
the complete tree will be performed to catch any other potential issues.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thierry Reding <[email protected]>
Thomas Gleixner <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Jeremy Cline <[email protected]>
Cc: Uwe Kleine-König <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
thierryreding authored and torvalds committed Dec 28, 2018
1 parent 919e9d3 commit b72231e
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions scripts/spdxcheck-test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/bin/sh

for PYTHON in python2 python3; do
# run check on a text and a binary file
for FILE in Makefile Documentation/logo.gif; do
$PYTHON scripts/spdxcheck.py $FILE
$PYTHON scripts/spdxcheck.py - < $FILE
done

# run check on complete tree to catch any other issues
$PYTHON scripts/spdxcheck.py > /dev/null
done

0 comments on commit b72231e

Please sign in to comment.