Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omnisharp.lua #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update omnisharp.lua #21

wants to merge 1 commit into from

Conversation

Ren-B-7
Copy link

@Ren-B-7 Ren-B-7 commented Nov 15, 2024

Add fdfind inline if statement, to fix the plugin for Ubuntu users

Added and tested inline statement for checking fd/ fdfind and locating root for directory

Add fdfind inline if statement
@Ren-B-7
Copy link
Author

Ren-B-7 commented Nov 15, 2024

Cant use vim.fn.executable() as a standalone, it returns an int {0, 1}, thus the inline if statement would always see it as true, and always use fdfind, even if not installed, or installed as fd
Needs to be explicit 1 to use fdfind

@jmartins-sh
Copy link
Contributor

jmartins-sh commented Nov 22, 2024

This test asserts the fd. Do we need to make any changes to it?

@Ren-B-7
Copy link
Author

Ren-B-7 commented Nov 22, 2024

The issue here is that the fd package is named fdfind on ubuntu and debian, since a package with the nickname fd already exists.

This update is to basically detect does fdfind exist? If yes then call that, with the fallback of fd.

Wish there was another way but i cant get the fd command passed down to child terminals with zsh. Thus this is a solution, might have to update the assert line as well, but it works for me on Ubuntu currently. (Working from my personal fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants