Setting hash fixed #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input never got created, therefor you'd get a null pointer exception in line 5 which is now line 6.
$('<tag></tag>') is not just slower but doesn't allow any attributes.
This should be faster and work just fine in any browser.
It deletes the textPlaceholder() call. Input (jQuery Object) does not have this method. Besides that there is no reference on what this method does anyways. This should work just fine.
This removes the call to textPlaceholer() on input (jQuery Document). There is no method textPlaceholder() and I can't find any reference for it. It seems to have no function but ends up to generate an exception.
|
+1 To this. Tested and works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest commit fixes three issues I was having.
I traced this down to the fact that the settings hash as stored in the Setting model had strings for the keys rather than symbols. When I changed all the keys from symbols to strings, the problems all went away.
My Environment:
Environment:
Redmine version 2.2.3.stable
Ruby version 1.9.2 (i686-linux)
Rails version 3.2.12
Environment production
Database adapter Mysql2
Redmine plugins:
AgileDwarf 0.0.3