Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Whatsapp file sharing and local download file sharing bug fixed #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nieldeokar
Copy link

  1. Fixed when you share file from whatsapp file path is inside "_display_name" column and not in default "_data".
  2. Fixed when you share file from local downloads you get NumberFormatException.

I was getting this errors on SDK 25,26.

@nik910
Copy link

nik910 commented Jan 25, 2018

This does not work

@nieldeokar
Copy link
Author

Hey,
Thanks for testing. Can you please let me know which part is not working? whatsapp file sharing or local downloads file sharing ?

@nik910
Copy link

nik910 commented Jan 25, 2018

@nieldeokar The whatsapp part is not working. The file.canRead method gives false and hence the path returned is null. Do we have to add any permissions in manifest for the above code to work?

@nieldeokar
Copy link
Author

I will update you on this after testing it once again. Thanks!

@nieldeokar
Copy link
Author

Actually in my app I am using FileUtils class for detecting incoming file Uri's from other apps. In which files coming from whatsapp were failing to resolve into their actual Uri. Anyone using FileUtils for same purpose would get benefited from it so I made the pull request.

But since FileChooserExample doesn't allow us to browse files from whatsapp it doesn't make any sense here. If you still want to test this feature you can add this intent-filter to FileChooserExampleActivity and check if you are able to resolve the Uri of whatsapp files.

<intent-filter>
              <action android:name="android.intent.action.SEND_MULTIPLE" />
              <action android:name="android.intent.action.SEND" />
              <category android:name="android.intent.category.DEFAULT" />
              <data android:mimeType="image/*" />
</intent-filter>

@nik910
Copy link

nik910 commented Jan 25, 2018

@nieldeokar its already included but it still does not work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants