enable MSP override build flag by default #10330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not so sure. With all the recent work with mLRS. There is potential that people will be sending MSP RC commands. |
|
I figured that it's an involved enough procedure that the possibility of someone sending them accidentally is pretty low, and you still need to set the override channels bitmask in CLI (ie: set msp_override_channels = 15 for 1,2,3,4) otherwise it has no effect on them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is safe to allow by default by now, a minority uses it but the chances of someone accidentally sending MSP RC commands is probably slim to none