Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Zerodrag WARP7 #10262

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vishnumda
Copy link

  • Added config.c, target.h, target.c and CMakeLists.txt

* Added config.c, target.h, target.c and CMakeLists.txt
@mmosca mmosca added the New target This PR adds a new target label Aug 1, 2024
@mmosca
Copy link
Collaborator

mmosca commented Aug 1, 2024

For tracking progress

WARP F7

  • Flash firmware
  • Calibrate
  • Orientation matches
  • Gyro working
  • Accel working
  • Baro working
  • Mag working (i2c)
  • Voltage correct
  • Current correct
  • UART1
  • UART2
  • UART3
  • UART4
  • UART5
  • Camera working
  • Video Out working
  • OSD working
  • LEDs working
  • Buzzer working
  • Motor/Servo outputs
  • Blackbox

@@ -0,0 +1 @@
target_stm32f722xe(WARPF7 SKIP_RELEASES)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want an official target, you should remove SKIP_RELEASES here.

@mmosca mmosca added this to the 8.0 milestone Aug 1, 2024

// Gyro & ACC
#define USE_IMU_ICM42605
#define IMU_ICM42605_ALIGN CW90_DEG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orientation is not correct. Seems off by 180 degrees.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been changed to CW270_DEG.

Copy link
Collaborator

@mmosca mmosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the board orientation and remove SKIP_RELEASES

Copy link
Collaborator

@mmosca mmosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of extra files have been added. Please remove all the uneed files, from outside the target folder.

@vishnumda
Copy link
Author

An old CMakeCache file was causing the build to fail. It has been removed.

@mmosca
Copy link
Collaborator

mmosca commented Aug 3, 2024

An old CMakeCache file was causing the build to fail. It has been removed.

There should only be the files in the target folder in this pr. there are still a lot of files that are not needed and should not be included.

@vishnumda vishnumda requested a review from mmosca August 3, 2024 10:09
@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2024

Adding some manual screenshots for reference.

image

image

image

// Others
#define MAX_PWM_OUTPUT_PORTS 8
#define USE_SERIAL_4WAY_BLHELI_INTERFACE
#define USE_DSHOT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dshot is not working, you also need #define USE_DSHOT_DMAR.

With USE_DSHOT_DMAR motor 2 is still not working. Probably need to adjust options in target.c

@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2024

@vishnumda is this T2 pad labeled correctly?

image

Never mind, had a short on my side. :)

@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2024

UART6 is missing in the target.

@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2024

Board also appears to have a Camera Control pin, but it is missing the definition and the timer for that.

Is P2 supposed to be PINIO output? If so,the PINIO definitions in target.h are missing.

#define USE_UART5
#define UART5_RX_PIN PD2
#define UART5_TX_PIN PC12
#define SERIAL_PORT_COUNT 6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UART6 is missing from the target.

DEF_TIM(TIM3, CH3, PC8, TIM_USE_OUTPUT_AUTO, 0, 0), // S6
//DEF_TIM(TIM8, CH3, PC8, TIM_USE_OUTPUT_AUTO, 0, 0),

DEF_TIM(TIM3, CH2, PC7, TIM_USE_OUTPUT_AUTO, 0, 0), // S7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are S7 and S9 exposed on the board?

DEF_TIM(TIM3, CH1, PC6, TIM_USE_OUTPUT_AUTO, 0, 0), // S8
//DEF_TIM(TIM8, CH1, PC6, TIM_USE_OUTPUT_AUTO, 0, 0),

DEF_TIM(TIM2, CH1, PA15, TIM_USE_BEEPER, 0, 0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIM2 conflicts with S4


// Format: DEF_TIM (tim, ch, pin, usage, flags, dmavar)
timerHardware_t timerHardware[] = {
DEF_TIM(TIM1, CH2N, PB0, TIM_USE_OUTPUT_AUTO, 0, 0), // S1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to switch the timer for S1 and S2 and it conflicts with your led timer.

Copy link
Collaborator

@mmosca mmosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the target to address the pr comments

@vishnumda
Copy link
Author

We are working on it.

@mmosca mmosca self-assigned this Aug 7, 2024
@mmosca mmosca removed this from the 8.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New target This PR adds a new target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants