support per-language CSS / fonts (for Japanese etc) #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sensei-hacker
force-pushed
the
language_specific_font
branch
3 times, most recently
from
da5703d to
090dd06
Compare
|
Needs to add currentLanguage to recently merged chinese translation |
sensei-hacker
force-pushed
the
language_specific_font
branch
9 times, most recently
from
09d3bb1 to
516ee8c
Compare
sensei-hacker
force-pushed
the
language_specific_font
branch
from
516ee8c to
d6b57e3
Compare
dd currentLanguage to zh_CN/messages.json
That has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some language translations need different CSS, such as an appropriate font.
That's done by setting the current language in the root html tag, such as:
[html lang="en"]
Or
[html lang="ja"]
This PR adds a case to allow:
[html i18n_lang="currentLanguage"]
This will allow an appropriate font to be used for Japanese ( #2250 ), and any other language-specific CSS.
To have an example of usage, I have added one line to the CSS to set an appropriate font when Japanese is selected.