Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name change from profile to control_profile #2247

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Nov 16, 2024

Fix for RC2

@MrD-RC MrD-RC added this to the 8.0 milestone Nov 16, 2024
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 16, 2024

Just thinking. I know these delays aren't the best way to do this. But shouldn't there also be a delay when switching the battery_profile or mixer_profile too?

@stronnag @Scavanger

@stronnag
Copy link
Collaborator

stronnag commented Nov 16, 2024

Just thinking. I know these delays aren't the best way to do this. But shouldn't there also be a delay when switching the battery_profile or mixer_profile too?

@stronnag @Scavanger

Yes, they should. All these *profile* items are more expensive than average. I re-ran the #1940 instrumentation, and the figures are pretty much the same for RC1.

So checking for whatever the JS equivalent of contains("_profile") is would be a better test.

@mmosca mmosca merged commit 4d3b90e into master Nov 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants