Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gimbal sensitivity from programming framework #2204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

error414
Copy link
Contributor

@error414 error414 commented Oct 7, 2024

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 7, 2024

Please separate these out in to 2 PRs

Also, I think the gimbal sensitivity adjustment would be better as an adjustment.

@error414 error414 force-pushed the change-gimbal-sensitivity-from-programming-framework branch from 03f1627 to 0fc75ec Compare October 7, 2024 18:52
@error414
Copy link
Contributor Author

error414 commented Oct 7, 2024

  1. fixed
  2. I'm not sure I understand

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 7, 2024

What do you mean?

Gimbal sensitivity adjustments would be better suited as "adjustments" rather than in the programming framework. I put more detail in a PR you made on the firmware side.

@error414 error414 force-pushed the change-gimbal-sensitivity-from-programming-framework branch from 0fc75ec to 9ead011 Compare October 9, 2024 08:47
@error414 error414 marked this pull request as ready for review October 27, 2024 21:51
@error414 error414 force-pushed the change-gimbal-sensitivity-from-programming-framework branch from 9ead011 to 2c6d1d5 Compare December 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants